Skip to content

add new email feature #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 3, 2021
Merged

add new email feature #1483

merged 10 commits into from
Jun 3, 2021

Conversation

caberos
Copy link
Contributor

@caberos caberos commented May 5, 2021

#1482

  • slcli email list
  • slcli email detail
  • slcli email edit

@caberos caberos requested review from allmightyspiff and ATGE May 5, 2021 13:55
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, thanks.

  • Change the CLI path to be slcli email list since this function lists out all accounts.
  • Update some of the function names to match the style of the rest of the slcli
  • Make the Stats/Overview tables into long column tables, not key value tables to look more compact
  • your get_statistics method should set some default values if none were supplied.

@ATGE ATGE linked an issue May 7, 2021 that may be closed by this pull request
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

  • ✔️slcli email -h
  • ✔️slcli email list
    Looks good,
$ slcli -h | grep email
  email

just shows the command email, adds a description and will look better.
something like:

$ slcli -h | grep email
  email Manage Email Delivery Service

you can add the descriptioon by adding:
"""Manage Email Delivery Service.""" in the SoftLayer/CLI/email/__init__.py file

  • add email in docs/cli.rst too

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the docblock in email/list.py and @ATGE's comments, and this should be good to go.

Thanks.

caberos and others added 2 commits May 24, 2021 20:44
add new email features, email detail and email edit
@allmightyspiff allmightyspiff merged commit 29b6931 into softlayer:master Jun 3, 2021
@allmightyspiff allmightyspiff linked an issue Jun 23, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add new email features, email detail and email edit new email feature
4 participants