-
Notifications
You must be signed in to change notification settings - Fork 192
add new email feature #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new email feature #1483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start, thanks.
- Change the CLI path to be
slcli email list
since this function lists out all accounts. - Update some of the function names to match the style of the rest of the slcli
- Make the Stats/Overview tables into long column tables, not key value tables to look more compact
- your
get_statistics
method should set some default values if none were supplied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing
- ✔️slcli email -h
- ✔️slcli email list
Looks good,
$ slcli -h | grep email
email
just shows the command email, adds a description and will look better.
something like:
$ slcli -h | grep email
email Manage Email Delivery Service
you can add the descriptioon by adding:
"""Manage Email Delivery Service.""" in the SoftLayer/CLI/email/__init__.py
file
- add email in
docs/cli.rst
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the docblock in email/list.py and @ATGE's comments, and this should be good to go.
Thanks.
add new email features, email detail and email edit
#1482
slcli email list
slcli email detail
slcli email edit