Skip to content

fix the network space is empty on subnet detail #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

fix the network space is empty on subnet detail #1523

merged 1 commit into from
Aug 2, 2021

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jul 27, 2021

@allmightyspiff allmightyspiff linked an issue Jul 27, 2021 that may be closed by this pull request
the network space return null on subnet detail #1522
Closed
allmightyspiff
allmightyspiff approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

FernandoOjeda
FernandoOjeda approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@FernandoOjeda FernandoOjeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ATGE
ATGE approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Testing

  • ✔️slcli subnet detail 2430000 | grep network

@allmightyspiff allmightyspiff merged commit ca1cad1 into softlayer:master Aug 2, 2021
@allmightyspiff allmightyspiff mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@ATGE ATGE ATGE approved these changes

@FernandoOjeda FernandoOjeda FernandoOjeda approved these changes

Assignees

@caberos caberos

Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the network space return null on subnet detail
4 participants
@caberos @allmightyspiff @ATGE @FernandoOjeda