Skip to content

slcli server create-options dal13 Error #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2021
Merged

slcli server create-options dal13 Error #1526

merged 4 commits into from
Aug 4, 2021

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Aug 2, 2021

FernandoOjeda
FernandoOjeda reviewed Aug 2, 2021
View reviewed changes
@allmightyspiff allmightyspiff added Bug Ordering Anything related to ordering labels Aug 2, 2021
@allmightyspiff allmightyspiff linked an issue Aug 2, 2021 that may be closed by this pull request
slcli server create-options dal13 Error #1525
Closed
allmightyspiff
allmightyspiff requested changes Aug 2, 2021
View reviewed changes
allmightyspiff
allmightyspiff requested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidently reverted your change to SoftLayer/managers/account.py, can you put the function back to def get_routers(self, location=None, mask=None): and this will be good to go. Sorry if there was any confusion about that.

allmightyspiff
allmightyspiff approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. thanks.

@allmightyspiff allmightyspiff merged commit 762ea75 into softlayer:master Aug 4, 2021
@allmightyspiff allmightyspiff mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoOjeda FernandoOjeda FernandoOjeda left review comments

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@caberos caberos

Labels
Bug Ordering Anything related to ordering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slcli server create-options dal13 Error
3 participants
@caberos @allmightyspiff @FernandoOjeda