Prevents SLCLI_VERSION environment variable from breaking things #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also updated the snapcraft release build to have a unique name since I want to use |
caberos
reviewed
Aug 3, 2021
There was a problem hiding this comment.
looks good
Testing
slcli --version
Current: slcli (SoftLayer Command-line) v5.9.5
Latest: slcli (SoftLayer Command-line) v5.9.6
slcli -v
Usage: slcli [OPTIONS] COMMAND [ARGS]...
Try "slcli -h" for help.
Error: Missing command.
slcli -v vs list
Calling: SoftLayer_Account::getVirtualGuests(id=None, mask='primaryIpAddress, activeTransaction[ id,transactionStatus[name,friendlyName] ],hostname,datacenter.name,id,primaryBackendIpAddress', filter='{}', args=(), limit=100, offset=0))
caberos
approved these changes
Aug 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1524
Apparently Click has a neat feature that allows you to set parameters with environment variables, which I just learned about.
https://github.com/softlayer/softlayer-python/blame/master/SoftLayer/CLI/core.py#L103 is what actually controls that, but since its been active for 3 years, I don't really want to turn it off entirely, as it is a somewhat neat feature.
So I'll just turn it off for --version which I don't think anyone would want to have automatically be set.