Skip to content

Forces specific endoing on XMLRPC requests #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

allmightyspiff
Copy link
Member

Fixes #1540

Most important change here is to SoftLayer\transports.py where I'm now forcibly encoding the payload, along with setting the encoding type for XML to encoding="iso-8859-1"

Other files being changed are for tox reasons

@allmightyspiff allmightyspiff added the Core Issues dealing with core functionality label Sep 1, 2021
@allmightyspiff allmightyspiff self-assigned this Sep 1, 2021
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@allmightyspiff allmightyspiff merged commit bf1a73d into softlayer:master Sep 3, 2021
@allmightyspiff allmightyspiff deleted the issues1540 branch September 3, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues dealing with core functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create users: No valid authentication headers found
2 participants