-
Notifications
You must be signed in to change notification settings - Fork 192
add new feature on vlan #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new feature on vlan #1572
Conversation
@BrianSantivanez / @edsonarios when you get a chance can you test this change to make sure it works as expected. Post some screenshots of the output, and any issues you may find when testing to this issue. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just capitalize the first letter of column headers. Also need some unit test coverage for the manager functions you added.
When I run the test, it is passing |
I test this new feature and I attache some screenshots But I think a help functionality is missing, for example in ibmcloud we have a description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
@edsonarios I think the options in the Might need to update the |
#1571