Skip to content

add new feature on vlan #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2022
Merged

add new feature on vlan #1572

merged 4 commits into from
Jan 18, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Dec 31, 2021

@allmightyspiff allmightyspiff linked an issue Jan 3, 2022 that may be closed by this pull request
@allmightyspiff
Copy link
Member

@BrianSantivanez / @edsonarios when you get a chance can you test this change to make sure it works as expected. Post some screenshots of the output, and any issues you may find when testing to this issue. Thanks

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just capitalize the first letter of column headers. Also need some unit test coverage for the manager functions you added.

@BrianSantivanez
Copy link

@BrianSantivanez / @edsonarios when you get a chance can you test this change to make sure it works as expected. Post some screenshots of the output, and any issues you may find when testing to this issue. Thanks

When I run the test, it is passing
image
The new feature is returning the datacenter and router options to create a vlan in table format and json format, it looks good to me.
image
image

@edsonarios
Copy link
Contributor

@BrianSantivanez / @edsonarios when you get a chance can you test this change to make sure it works as expected. Post some screenshots of the output, and any issues you may find when testing to this issue. Thanks

I test this new feature and I attache some screenshots
In performance, it takes about 50 seconds to deliver the result
image
image

But I think a help functionality is missing, for example in ibmcloud we have a description
image
image

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@allmightyspiff
Copy link
Member

@edsonarios I think the options in the ibmcloud command are actually a bit out of date. Currently you really only need the router/datacenter when ordering a VLAN.

image

Might need to update the ibmcloud command to reflect that though.

@allmightyspiff allmightyspiff merged commit 6539959 into softlayer:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add vlan create-options
4 participants