New command for getting duplicate convert status #1655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
approved these changes
May 27, 2022
caberos
suggested changes
May 30, 2022
| @@ -577,3 +577,12 @@ def convert_dep_dupe(self, volume_id): | |||
| return self.client.call('Network_Storage', | |||
| 'convertCloneDependentToIndependent', | |||
| id=volume_id) | |||
|
|
|||
| def split_percentage(self, volume_id): | |||
| """Get the Clone split/move status completion of a duplicate volume | |||
There was a problem hiding this comment.
please put the link reference
There was a problem hiding this comment.
ahh.. which link reference you are asking here @caberos ...jira for API that's consuming this - https://jira.softlayer.local/browse/FBLOCK-4520
| @environment.pass_env | ||
| def cli(env, volume_id): | ||
| """Get status for split or move completed percentage of a given file duplicate volume.""" | ||
| table = formatting.Table(['username', 'active_conversion_start_time', 'completed_percentage']) |
| @environment.pass_env | ||
| def cli(env, volume_id): | ||
| """Get status for split or move completed percentage of a given file duplicate volume.""" | ||
| table = formatting.Table(['username', 'active_conversion_start_time', 'completed_percentage']) |
There was a problem hiding this comment.
Suggested change
| table = formatting.Table(['username', 'active_conversion_start_time', 'completed_percentage']) | |
| table = formatting.Table(['Username', 'Active conversion start', 'Completed percentage']) |
|
|
||
| file_manager = SoftLayer.FileStorageManager(env.client) | ||
|
|
||
| value = file_manager.split_percentage( |
There was a problem hiding this comment.
Suggested change
| value = file_manager.split_percentage( | |
| value = file_manager.split_percentage(volume_id) |
|
|
||
| block_manager = SoftLayer.BlockStorageManager(env.client) | ||
|
|
||
| value = block_manager.split_percentage( |
There was a problem hiding this comment.
Suggested change
| value = block_manager.split_percentage( | |
| value = block_manager.split_percentage(volume_id) |
|
Attached images for review |
|
Hi @allmightyspiff , the api has released yesterday IST, Requesting you to please merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature for getting duplicate split/move completion status .
Command name : duplicate-convert-status