Skip to content

add firewall monitoring command #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 14, 2022
Merged

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jun 2, 2022

#issue1654

slcli firewall monitoring firewallId

┌────────────┬─────────────────────┐
│ name │ value │
├────────────┼─────────────────────┤
│ Id │ 17438 │
│ Name │ testFirewall-cgallo │
│ Stard Date │ 2022-05-02 │
│ End Date │ 2022-06-01 │
│ Out │ 62852476.0 │
│ In │ 89715092.0 │
│ Total │ 152567568.0 │
│ Status │ Active │
└────────────┴─────────────────────┘

@BrianSantivanez
Copy link

Running command with multi vlan firewall id
image
Running command with single server firewall id
image
Running help command
image

The command should display an error message saying that single server firewalls does not have monitors or in other case update help command to say that command only accepts multi vlan firewall Ids

@caberos
Copy link
Contributor Author

caberos commented Jun 9, 2022

only accepts multi vlan firewall because it has a metric tracking object for show the usage and monitoring the its data(input and output information), I will update the description and requeriments to use in this command
image

@allmightyspiff allmightyspiff linked an issue Jun 10, 2022 that may be closed by this pull request
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just a few minor changes. Also I'd like this command to be called 'slcli firewall bandwidth` as that would align better with the hw and vs bandwidth commands.

For a monitoring command, I would expect it to tell me if the system is UP/DOWN and things like that.

Thanks

@allmightyspiff allmightyspiff merged commit 7c5698b into softlayer:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add firewall monitoring
3 participants