Skip to content

Fixed TOX errors #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SoftLayer/CLI/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from SoftLayer.CLI import formatting
from SoftLayer.CLI import routes

# pylint: disable=too-many-instance-attributes, invalid-name, no-self-use
# pylint: disable=too-many-instance-attributes, invalid-name

# Calling pkg_resources.iter_entry_points shows a false-positive
# pylint: disable=no-member
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

:license: MIT, see LICENSE for more details.
"""
# pylint: disable=no-self-use


__all__ = [
'BasicAuthentication',
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/account.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from SoftLayer import utils

# Invalid names are ignored due to long method names and short argument names
# pylint: disable=invalid-name, no-self-use
# pylint: disable=invalid-name

LOGGER = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/cdn.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from SoftLayer import utils


# pylint: disable=no-self-use,too-many-lines,too-many-instance-attributes
# pylint: disable=too-many-lines,too-many-instance-attributes


class CDNManager(utils.IdentifierMixin, object):
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/dedicated_host.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from SoftLayer import utils

# Invalid names are ignored due to long method names and short argument names
# pylint: disable=invalid-name, no-self-use
# pylint: disable=invalid-name

LOGGER = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/email.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


# Invalid names are ignored due to long method names and short argument names
# pylint: disable=invalid-name, no-self-use
# pylint: disable=invalid-name


class EmailManager(utils.IdentifierMixin, object):
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/hardware.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
LOGGER = logging.getLogger(__name__)

# Invalid names are ignored due to long method names and short argument names
# pylint: disable=invalid-name, no-self-use, too-many-lines
# pylint: disable=invalid-name, too-many-lines

EXTRA_CATEGORIES = ['pri_ipv6_addresses',
'static_ipv6_addresses',
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/ordering.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

:license: MIT, see LICENSE for more details.
"""
# pylint: disable=no-self-use


from re import match

Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def __init__(self, client):
self.client = client
self.resolvers = [self._get_ids_from_username]

def _get_ids_from_username(self, username): # pylint: disable=unused-argument,no-self-use
def _get_ids_from_username(self, username): # pylint: disable=unused-argument
"""Should only be actually called from the block/file manager"""
return []

Expand Down
6 changes: 3 additions & 3 deletions SoftLayer/managers/vs.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
'software_guard_extensions']


# pylint: disable=no-self-use,too-many-lines
# pylint: disable=,too-many-lines


class VSManager(utils.IdentifierMixin, object):
Expand Down Expand Up @@ -360,7 +360,7 @@ def get_create_options(self, vsi_type="PUBLIC_CLOUD_SERVER", datacenter=None):
'prices': get_item_price(item['prices'], location_group_id)
})

elif category.__contains__('guest_disk'):
elif 'guest_disk' in category:
local_disk.append({
'name': item['description'],
'capacity': item['capacity'],
Expand Down Expand Up @@ -1043,7 +1043,7 @@ def upgrade(self, instance_id, cpus=None, memory=None, nic_speed=None, public=Tr
disk_number = 0
vsi_disk = self.get_instance(instance_id)
for item in vsi_disk.get('billingItem').get('children'):
if item.get('categoryCode').__contains__('guest_disk'):
if 'guest_disk' in item.get('categoryCode'):
if disk_number < int("".join(filter(str.isdigit, item.get('categoryCode')))):
disk_number = int("".join(filter(str.isdigit, item.get('categoryCode'))))
for disk_guest in disk:
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/vs_capacity.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from SoftLayer import utils

# Invalid names are ignored due to long method names and short argument names
# pylint: disable=invalid-name, no-self-use
# pylint: disable=invalid-name

LOGGER = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/vs_placement.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from SoftLayer import utils

# Invalid names are ignored due to long method names and short argument names
# pylint: disable=invalid-name, no-self-use
# pylint: disable=invalid-name

LOGGER = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/transports/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from .xmlrpc import XmlRpcTransport

# transports.Request does have a lot of instance attributes. :(
# pylint: disable=too-many-instance-attributes, no-self-use
# pylint: disable=too-many-instance-attributes

__all__ = [
'Request',
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/transports/transport.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def get_session(user_agent):


# transports.Request does have a lot of instance attributes. :(
# pylint: disable=too-many-instance-attributes, no-self-use
# pylint: disable=too-many-instance-attributes
class Request(object):
"""Transport request object."""

Expand Down
2 changes: 0 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ commands =
-r n \
--ignore=tests,fixtures \
-d too-many-locals \
-d star-args \
-d redefined-variable-type \
-d locally-disabled \
-d no-else-return \
-d len-as-condition \
Expand Down