Skip to content

Add marshmallow-dataclasses as dependency #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cptartur opened this issue Jan 12, 2023 · 1 comment · Fixed by #649
Closed

Add marshmallow-dataclasses as dependency #662

cptartur opened this issue Jan 12, 2023 · 1 comment · Fixed by #649
Assignees
@war-in
Labels
enhancement New feature or request

Comments

@cptartur
Copy link
Member

Feature Request

Since #649 is using marshmallow-dataclasses, we should add it as a package dependency. Currently it only works because cairo-lang installs marshmallow-dataclasses as its own dependency.

We should also limit the maximum version of the package to below 8.5.5, until the lovasoa/marshmallow_dataclass#198 memory leak gets addressed.
@cptartur cptartur added the enhancement New feature or request label Jan 12, 2023
@cptartur
Copy link
Member Author

cc @war-in

@war-in war-in self-assigned this Jan 12, 2023
@war-in war-in mentioned this issue Jan 12, 2023
Merged
1 task
@war-in war-in linked a pull request Jan 12, 2023 that will close this issue
Add dataclasses for transactions #649
Merged
1 task
@war-in war-in closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@war-in war-in

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dataclasses for transactions software-mansion/starknet.py
2 participants
@cptartur @war-in