Add dataclasses for transactions #649

war-in · 2023-01-09T14:10:07Z

Closes #640
Closes #634
Closes #662

Introduced changes

Transactions from cairo-lang are replaced with our implementation
QUERY_VERSION_BASE is removed

This PR contains breaking changes

…ation

…d-dataclasses-for-transactions

codecov · 2023-01-10T10:10:30Z

Codecov Report

❗ No coverage uploaded for pull request base (refactor/remove-cairo-lang-dependency@8b18177). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@                           Coverage Diff                            @@
##             refactor/remove-cairo-lang-dependency     #649   +/-   ##
========================================================================
  Coverage                                         ?   97.49%           
========================================================================
  Files                                            ?       57           
  Lines                                            ?     2796           
  Branches                                         ?        0           
========================================================================
  Hits                                             ?     2726           
  Misses                                           ?       70           
  Partials                                         ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/models.rst

starknet_py/net/account/account.py

starknet_py/net/account/account_client.py

starknet_py/net/gateway_client.py

starknet_py/net/models/transaction.py

This reverts commit 7e0a163.

cptartur

Let's try to address the issue with our typing currently requiring casts in multiple places. Otherwise looks mostly good.

starknet_py/net/schemas/common.py

starknet_py/net/models/transaction.py

* Remove usages of `CastableToHash` (#587) * Remove CastableToHash import * Change hash to int * Replace `FIELD_PRIME` in felt.py (#588) * Add FIELD_PRIME constant * Change FIELD_PRIME to hex * Replace `get_random_private_key` (#597) * Replace get_random_private_key * Change key generation method * Move func to test utils * Add comment * Replace `get_selector_from_name` and `get_storage_var_address` implementations (#586) * Remove uses of starkware.starknet.public.api * Add eth-utils dependency * Change import path * Apply review * Move functions to separate files * Fix path in cairo-lang comment * Add unit tests * Remove `ContractAddressSalt.get_random_value()` usages (#596) * add custom `get_random_value` * fix imports * rename to `get_random_salt` * move `get_random_salt` to deployer.py * make it private * do not use private `get_random_salt` * Replace `compute_hash_on_elements` (#602) * replace compute_hash_on_elements * replace calculate_contract_address_from_hash * remove unused PREFIX_TRANSACTION * add tests * fix pyright * add type for data * Update starknet_py/utils/crypto/facade.py Co-authored-by: Kamil Jankowski <[email protected]> * move to constants * remove unnecessary function * remove `hash_call_with` function & `hash_func` parameter * fix the imports Co-authored-by: Kamil Jankowski <[email protected]> * Replace transaction hash calculation (#621) * add functions to compute transaction hashes * replace usages from starkware * deprecate compute_invoke_hash * add tests * rename to compute_transaction_hash * fix error * add docstrings * replace 0 with DEFAULT_ENTRY_POINT_SELECTOR * modify test case * update lock * fixes after merge * update lock * fix imports in the `fmt: off` files * fix import * Add dataclasses for transactions (#649) * `Declare` is working :o * format * [wip] adding transactions * it is working! * format * remove QUERY_VERSION_BASE and change TransactionType to own implementation * change `general_config` to `chain_id` * [wip] bulk * format * repair bulk * remove unused blockIdentifier * bring DEFAULT_DECLARE_SENDER_ADDRESS to constants * fix import * add tx_type as @classmethod * DEFAULT_DECLARE_SENDER_ADDRESS = 1 * post-merge fixes * fix typing errors * format * resolve last typing issues * format * remove unnecessary file * update docstrings and comments in transaction.py * format * Update starknet_py/net/account/account_client.py Co-authored-by: Kamil Jankowski <[email protected]> * rename `InvokeFunction` to `Invoke` * apply part of the review changes. The biggest one: remove SignableTransaction and replace it with AccountTransaction * tx_type as a property * fix docs * rename `tx_type` to `type` remove unnecessary `post_dump` method * format * remove comment * make `_remove_entry_point_selector` private * remove duplicated TransactionType * NoneFelt docstring * fix docs * review suggestions * _prepare_invoke_function -> _prepare_invoke * add marshmallow-dataclass as dependency * InvokeFunction -> Invoke in the docstring * update typing * Revert "add marshmallow-dataclass as dependency" This reverts commit 7e0a163. * change marshmallow-dataclass version * remove casting * remove types.py * move `pylint:disable` Co-authored-by: Kamil Jankowski <[email protected]> * Replace compress and decompress program (#683) * Use own compress and decompress program * Fix lint * Fix typing * Inline `_compress_program` * Add basic Declare test * Fix tests typing * Remove `_contract_attribute_name` * remove unused imports * update lock * rename function * add ABC to the AccountTransaction * update base signer interface * update comment * move MASK_250 * Migration guide (remove cairo lang) (#670) * migration guide v1 * add `the` * add info about imports * formatting * Update docs/migration_guide.rst Co-authored-by: Artur Michałek <[email protected]> * add `Transaction's dataclasses` section * fix bullet list * remove unnecessary line * suggested changes * Update docs/migration_guide.rst Co-authored-by: Artur Michałek <[email protected]> * review suggestions Co-authored-by: Artur Michałek <[email protected]> * clean after merge * update lock * format * aftermerge fixes * fix types * fix failing docs * add tests for `Transaction.calculate_hash` * Replace`StarkErrorCode` (#737) * remove usage of StarknetErrorCode * one last usage of `get_selector_from_name` from cairo lang * Support calculating class_hash (#660) * Add compute_class_hash * Add tests * Add tests * Remove pre-0.10.0 class_hash calculation * Fix sorted keys in serialized class * Remove else branch * Remove else branch * Hash module (#677) * Create hash module * Format * Fix docs build * Add docstrings * Add pedersen_hash tests * Format * Fix test * Replace ContractClass (#686) * Rename DeclaredContract to ContractClass * Replace ContractClass * Restore class hash < 0.10.0 [WIP] * Use re.sub * Remove int casting * Add tests * Add compute_class_hash * Remove pre-0.10.0 class_hash calculation * Fix sorted keys in serialized class * Remove else branch * Remove else branch * Hash module (#677) * Create hash module * Format * Fix docs build * Add docstrings * Add pedersen_hash tests * Format * Fix test * Replace ContractClass (#686) * Rename DeclaredContract to ContractClass * Replace ContractClass * Restore class hash < 0.10.0 [WIP] * Use re.sub * Remove int casting * Post merge fixes * Rename contract_class module * Update starknet_py/hash/class_hash.py * Add create_contract_class to compiler module * Apply review * Apply suggestions from code review Co-authored-by: Artur Michałek <[email protected]> * Add CompiledContract (#708) * Add CompiledContract * Review * Add suggestions from review * Remove factory method * Fix ci * Default abi to empty list * Post merge * Fix circular import * Remove annotations import --------- Co-authored-by: Artur Michałek <[email protected]> Co-authored-by: war-in <[email protected]> * Add comment about default_factory * Fix lock * Validate class_hash with cairo-lang * Replace imports of already implemented methods * Update migration guide * Change deprecation version * Circular imports detection (#760) * Add circular.py * Fix circular imports * Remove import * Update circular.py Co-authored-by: war-in <[email protected]> * Add circular check to CI * Fix CI --------- Co-authored-by: war-in <[email protected]> * Fix lock * Fix lint * Final changes * Fix docs --------- Co-authored-by: Kamil Jankowski <[email protected]> Co-authored-by: Artur Michałek <[email protected]>

war-in added 15 commits January 5, 2023 16:03

Declare is working :o

b853644

format

5890205

[wip] adding transactions

bb51017

it is working!

fadceca

format

374230c

remove QUERY_VERSION_BASE and change TransactionType to own implement…

9e70744

…ation

change general_config to chain_id

c9ae359

[wip] bulk

ddeb12a

format

25ef237

repair bulk

086fdbe

remove unused blockIdentifier

6db9b76

bring DEFAULT_DECLARE_SENDER_ADDRESS to constants

aaa6ef3

fix import

ca0e353

add tx_type as @classmethod

7df661b

DEFAULT_DECLARE_SENDER_ADDRESS = 1

e6ea374

war-in requested review from cptartur and drknzz January 9, 2023 14:10

war-in and others added 2 commits January 9, 2023 15:10

Merge branch 'refactor/remove-cairo-lang-dependency' into refactor/ad…

a121bcb

…d-dataclasses-for-transactions

post-merge fixes

caf28af

war-in marked this pull request as draft January 9, 2023 14:42

This was linked to issues Jan 10, 2023

Replace transactions dataclasses from the cairo-lang #634

Closed

Consider removing QUERY_VERSION_BASE from the Removing part of cairo-lang dependency #640

Closed

war-in added 4 commits January 10, 2023 10:36

fix typing errors

708aec5

format

cce4a9f

resolve last typing issues

78617ea

format

849ca96

war-in self-assigned this Jan 10, 2023

war-in added 2 commits January 10, 2023 12:00

remove unnecessary file

7756bb6

update docstrings and comments in transaction.py

0c58d4d

war-in added 5 commits January 11, 2023 09:25

remove comment

f920d3e

make _remove_entry_point_selector private

db65e23

remove duplicated TransactionType

a054f70

NoneFelt docstring

d9ab15a

fix docs

d53f04e

war-in mentioned this pull request Jan 11, 2023

Replace compress_program and decompress_program #658

Closed

war-in requested review from cptartur and drknzz January 11, 2023 10:03

drknzz reviewed Jan 12, 2023

View reviewed changes

review suggestions

ff0a066

cptartur mentioned this pull request Jan 12, 2023

Add marshmallow-dataclasses as dependency #662

Closed

war-in added 2 commits January 12, 2023 11:04

_prepare_invoke_function -> _prepare_invoke

a7672ed

add marshmallow-dataclass as dependency

7e0a163

war-in linked an issue Jan 12, 2023 that may be closed by this pull request

Add marshmallow-dataclasses as dependency #662

Closed

war-in added 3 commits January 12, 2023 11:13

InvokeFunction -> Invoke in the docstring

e9572a0

update typing

1045da6

Revert "add marshmallow-dataclass as dependency"

98a5bed

This reverts commit 7e0a163.

cptartur reviewed Jan 12, 2023

View reviewed changes

starknet_py/net/schemas/common.py Show resolved Hide resolved

war-in added 2 commits January 12, 2023 11:36

change marshmallow-dataclass version

78f3ac5

remove casting

5c20f56

drknzz reviewed Jan 12, 2023

View reviewed changes

starknet_py/net/models/transaction.py Show resolved Hide resolved

remove types.py

f6247de

drknzz reviewed Jan 13, 2023

View reviewed changes

starknet_py/net/models/transaction.py Outdated Show resolved Hide resolved

move pylint:disable

b542c0a

drknzz approved these changes Jan 13, 2023

View reviewed changes

cptartur approved these changes Jan 13, 2023

View reviewed changes

war-in merged commit 169d6a5 into refactor/remove-cairo-lang-dependency Jan 13, 2023

war-in deleted the refactor/add-dataclasses-for-transactions branch January 13, 2023 11:13

drknzz mentioned this pull request Feb 17, 2023

Remove transaction dataclasses in client_models.py #774

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add dataclasses for transactions #649

Add dataclasses for transactions #649

Uh oh!

war-in commented Jan 9, 2023 •

edited

Loading

Uh oh!

codecov bot commented Jan 10, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cptartur left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add dataclasses for transactions #649

Add dataclasses for transactions #649

Uh oh!

Conversation

war-in commented Jan 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introduced changes

Uh oh!

codecov bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cptartur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in commented Jan 9, 2023 •

edited

Loading

codecov bot commented Jan 10, 2023 •

edited

Loading