Skip to content

Remove transaction dataclasses in client_models.py #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drknzz opened this issue Feb 17, 2023 · 2 comments · Fixed by #815
Closed

Remove transaction dataclasses in client_models.py #774

drknzz opened this issue Feb 17, 2023 · 2 comments · Fixed by #815
Assignees
Labels
Milestone

Comments

@drknzz
Copy link
Contributor

drknzz commented Feb 17, 2023

Feature Request

New transaction dataclasses have been added in #649, leaving us with 2 dataclasses for each transaction:

net/models/transaction.py
net/client_models.py

We should possibly remove the old transaction classes and replace their usages with the new ones.

@drknzz drknzz added the enhancement New feature or request label Feb 17, 2023
@cptartur cptartur added this to the Refactor milestone Feb 22, 2023
@cptartur
Copy link
Member

Blocked after 0.11.0. This should be a part of the general refactor I think.

@cptartur
Copy link
Member

cptartur commented Mar 1, 2023

Transactions returned from gateway are different than the ones we send. They cannot be combined.

@drknzz drknzz mentioned this issue Mar 1, 2023
1 task
@drknzz drknzz self-assigned this Mar 1, 2023
@drknzz drknzz linked a pull request Mar 8, 2023 that will close this issue
1 task
@drknzz drknzz closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants