Skip to content

version bumps, then add JDK 11 and 17 to CI matrix #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2021
Merged

version bumps, then add JDK 11 and 17 to CI matrix #162

merged 3 commits into from
Jun 23, 2021

Conversation

SethTisue
Copy link
Contributor

No description provided.

@SethTisue
Copy link
Contributor Author

SethTisue commented Jun 22, 2021 •
edited
Loading

Looks like Travis-CI isn't working, so I don't know if this is actually mergeable.

I don't actually have an interest in seeing this merged. My motivation here is simply to inform you that macwire's tests fail on JDK 17, because of https://openjdk.java.net/jeps/403, as seen at https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/15/artifact/logs/macwire-build.log

@SethTisue SethTisue marked this pull request as draft June 22, 2021 18:34
@SethTisue SethTisue mentioned this pull request Jun 22, 2021
Closed
9 tasks
@adamw adamw marked this pull request as ready for review June 23, 2021 17:46
@adamw adamw merged commit 29432ac into softwaremill:master Jun 23, 2021
@SethTisue SethTisue deleted the jdk17 branch June 23, 2021 17:58
@adamw
Copy link
Member

adamw commented Jun 23, 2021

Thanks! I'll take the occasion to modernize the build & move it to GH Actions. I think it should support jdk 17 builds as well, at least I'll try to add them :)

@adamw
Copy link
Member

adamw commented Jun 23, 2021

Hm no, the latest available on GH actions (at least using setup-java) is 16. Anyway, I've opened #163 to investigate & fix this further.

@SethTisue
Copy link
Contributor Author

Hm no, the latest available on GH actions (at least using setup-java) is 16

try 17-ea (instead of just plain 17)

@adamw
Copy link
Member

adamw commented Jun 23, 2021

Ha, I think this worked. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @adamw