This repository was archived by the owner on Mar 11, 2025. It is now read-only.
stake-pool: Add DecreaseAdditionalValidatorStake instruction
#3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
reviewed
Dec 23, 2022
stake-pool/program/src/processor.rs
Outdated
Comment on lines
1250
to
1251
| if let Some(ephemeral_stake_seed) = maybe_ephemeral_stake_seed { | ||
| let ephemeral_stake_account_info = maybe_ephemeral_stake_account_info.unwrap(); |
There was a problem hiding this comment.
presume you want to port trents suggestion here also
There was a problem hiding this comment.
Yeah, I'll merge the other one first, rebase, then make that change, thanks for spotting
|
lgtm! |
joncinque
force-pushed
the
sp-redecrease
branch
from
8e35844 to
5d754f4
Compare
|
Merging this to give auditors a clean commit hash to look at -- post-merge reviews are always welcome! |
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
…a-labs#3925) * stake-pool: Add `DecreaseAdditionalValidatorStake` instruction * Update checks for deduping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible to do multiple increases in a stake pool with #3924, but this is also possible with decreases!
Solution
There's nothing technically stopping two deactivating stakes from merging, so introduce a new instruction on the stake pool program which allows for more decreases in an epoch.
The normal instruction splits into the transient account and then deactivates it, so this instruction:
The implementation is extremely similar to #3924, and this instruction is less important, so be sure to check this out afterwards.