Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

docs: documentation for account compression program #3998

Merged

Conversation

anoushk1234
Copy link
Contributor

I've added documentation for the account compression program. Here's a summary of the changes.

I've added 3 pages:

  • overview
  • usage
  • core concepts

Overview contains brief on the program, motivation, background, packages and guide to run the tests.
Usage contains examples to use the TS SDK
Core concepts contains a concise explanation of the core technology used in account compression and how it ties into compressing NFTs with easy to understand examples.

@mergify mergify bot added the community Community contribution label Jan 25, 2023
@ngundotra
Copy link
Contributor

TS usage / examples look good. Explanation of algorithm is excellent, but a little bit off. Will highlight particular lines

Can you explain what the package.json changes are for?

@anoushk1234
Copy link
Contributor Author

TS usage / examples look good. Explanation of algorithm is excellent, but a little bit off. Will highlight particular lines

Can you explain what the package.json changes are for?

Docusaurus wasn't serving the page for me on localhost 3000 without specifying the host and port on the start command, after that it did serve the page but gave an error saying switchConfig is undefined which was fixed after updating the packages

@ngundotra
Copy link
Contributor

Please undo your package json changes

@ngundotra
Copy link
Contributor

Otherwise, this looks good. Will need some touch up after merging, but looks good to me. Great work!

Can you remove the digital asset examples? Those are bound to be out of date soon

@anoushk1234
Copy link
Contributor Author

Otherwise, this looks good. Will need some touch up after merging, but looks good to me. Great work!

Can you remove the digital asset examples? Those are bound to be out of date soon

Thanks! Made both the changes, glad I could contribute and thanks for coordinating, looking forward to doing more contributions

@ngundotra
Copy link
Contributor

Looks good to me. cc @joncinque for help with reviewing changes to Docusaurus

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me, just one little nit to move the section down

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll let you merge it

@ngundotra ngundotra merged commit 4c0b110 into solana-labs:master Jan 27, 2023
HaoranYi pushed a commit to HaoranYi/solana-program-library that referenced this pull request Jul 19, 2023
* docs: added account compression to sidebar

* docs: added account compression page

* docs: added concepts

* docs: added more core concepts + usage docs

* fix: remove extra column in table

* fix: fixed error in swap example

* fix: revert package.json changes for docs

* docs: remove digital asset ex from compression docs

* Address nit

---------

Co-authored-by: Noah Gundotra <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants