This repository was archived by the owner on Mar 11, 2025. It is now read-only.
stake-pool: Specify the space used for new stake accounts (OS-SSP-SUG-00) #4000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure rent-exempt calculations are performed on actual data size instead of theoretical data size. E.g.
in AddValidatorToPool, rent exempt calculation on the reserve_pool is performed on the default
account size:
If it was possible to create a Stake account larger than the default (200 bytes), this computation would
be inaccurate and the stake account may be able to be closed here.
Note: the stake program validates the account size during initialization and during split the remaining
lamports must be either greater than the minimum requirement or zero.
Remediation
Calculate minimum rent based on the actual size of the account to be created.
In all other places, we're using the
rent_exempt_reserve
reported on the stake account'sMeta
, so we're safe there.