This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump & publish
@solana/spl-token-group
version0.0.5
to include any recent changes to dependencies.Then bump & publish
@solana/spl-token
version0.4.8
to include the newer Token Group JS, eliminating the dependency on the deprecated version.Closes #6958
SPL JS Postbuild Step
In our repository, we build and publish packages using
pnpm
version8.14.3
(see workspace package.json). There are a few ways you can configure a matchingpnpm
version locally, but I use the following command, since my global version is 9.5.0.When using the proper version of
pnpm
and - after installing all packages - running the build step from the workspace root (ie.,npx [email protected] run build
), the postbuild step that configures the CJS output is successfully run by Turbo.However, if you run this command within any package's local directory, for example
token/js
, Turbo won't be used, and insteadpnpm
is used directly to call the script in that package's package.json. In this situation, the post-build step is not run.pnpm
version 9 includes pre- and post-build scripts by default, so whenever SPL's version ofpnpm
is upgraded we will no longer need to worry about this crucial pre-publish step being missed. However, as a precaution, and to solve the issue forpnpm
version 8, I've added the following configuration in a.npmrc
file:See the discussion on the
pnpm
repository or this blog for more information.