This repository was archived by the owner on Mar 11, 2025. It is now read-only.
remove solana-program from token-group-interface #7430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Oct 31, 2024
token-group/interface/src/state.rs
Outdated
There was a problem hiding this comment.
Is there a reason that you didn't update the usage of solana_program at the top of this file?
There was a problem hiding this comment.
nope just missed it
token-group/interface/Cargo.toml
Outdated
| num-traits = "0.2" | ||
| solana-decode-error = "2.1.0" | ||
| solana-instruction = "2.1.0" | ||
| solana-msg = "2.1.0" | ||
| solana-program = "2.1.0" |
There was a problem hiding this comment.
It looks the only usage of solana-program can be removed from state.rs, see my other comment
joncinque
approved these changes
Oct 31, 2024
|
CI error is being fixed in #7432 |
buffalojoec
reviewed
Oct 31, 2024
Comment on lines
+10
to
+11
| #[repr(u32)] | ||
| #[derive(Clone, Debug, Eq, thiserror::Error, num_derive::FromPrimitive, PartialEq)] |
There was a problem hiding this comment.
Why not just update the macro?
There was a problem hiding this comment.
I tried, but that macro is quite tied to the assumption that there is a single solana_program crate that we import, and I didn't find a way to update it without breaking everything
There was a problem hiding this comment.
This is my fault, remember #7112?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated imports and replace spl_program_error usage with inline impls