Update transform_id for W3C Metadata creation and Reporter init #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are custom-distro updates to use W3C-related liboboe features that were added after Martin's departure.
(1)
Updates
transform_idin the Python custom-distro to create a W3C-style trace context because liboboe can now accept these forMetadata::fromStringcreation. No need for AO2Bcontext on the agent side.With this change the testbed can report traces to:
AO staging, through java-collector proxy
NH staging (dc-01), through java-collector proxy
This can be queried using the GraphQL playground
traceId: A46AFE5BEA66C9FFC2A2CCC5C95AE039
NH staging (dc-01) directly
This can be queried using the GraphQL playground
traceId: BC93DC63C3B7E54D5AEBF2D9F99DAEC1
(2)
Reporterinit by theSolarWindsSpanExporteris done withw3c_trace_format=1which works for export of traces to AO or NH (i.e. the above examples).(3)
I don't test with the otel-oboe repo anymore because it is so far behind liboboe. Therefore the readme, Makefile, shell script all point to a local checked-out liboboe that should be on the experimental branch I'm working off of: https://github.com/librato/oboe/compare/add-otel-oboe-features