Runtime Metadata V14 support #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2021 23:48
Added V14 runtimes hex files Implemented parsing of runtime metadata V14 Fixed tests Fixed usages Fixed some warnings in old files
Viscount88
approved these changes
Dec 1, 2021
added 13 commits
December 15, 2021 12:14
added 5 commits
December 23, 2021 13:03
Updated Starscream URL Bumped version Returned HEX coding for Data (need to fix v14 with this) Updated JSON files for legacy schemas, fixed their some default values Fixed some tests
Viscount88
approved these changes
Dec 29, 2021
| // MARK: - Schema | ||
|
|
||
| public struct Schema: ScaleCodable { | ||
| public let types: [SchemaItem] |
| value: TypeMetadata.Def.Composite, | ||
| mediator: TypeRegistering | ||
| ) throws -> Node { | ||
| // if value.fields.count == 1 { |
There was a problem hiding this comment.
It'll be nice to have some comment or TODO about why we need this
| } | ||
| } | ||
|
|
||
| guard let mapping = mapping else { |
There was a problem hiding this comment.
Can be combined with the conditional statement above
| } | ||
| } | ||
|
|
||
| guard let components = components else { |
There was a problem hiding this comment.
Can be combined with the conditional statement above
| @@ -3,21 +3,31 @@ import Foundation | |||
| public class HexCodingStrategy { | |||
| static func encoding(data: Data, encoder: Encoder) throws { | |||
| var container = encoder.singleValueContainer() | |||
| let hex = data.toHex(includePrefix: true) | |||
| try container.encode(hex) | |||
| let array = data.map { String($0) } | |||
There was a problem hiding this comment.
Looks like it's not "hex" coding strategy anymore. Just confusing class naming, imho
| ], | ||
| extrinsic: ExtrinsicMetadata(version: 1, | ||
| signedExtensions: [])) | ||
| RuntimeMetadata.v1( |
There was a problem hiding this comment.
Should we have same for v14? Of course, no time for tests now, but mb it'll be useful to have TODO here?
| version: 9010 | ||
| ) | ||
| } | ||
| // Seems outdated |
There was a problem hiding this comment.
Is it outdated? Or it can be helpful someday?
Viscount88
approved these changes
Dec 30, 2021
| // MARK: - V14 | ||
|
|
||
| extension RuntimeMetadataV14 { | ||
| public struct EventMetadata: RuntimeEventMetadata { |
There was a problem hiding this comment.
We can have single event metadata with two different inits.
… optimize create runtime snapshot func
…ferent generic types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added V14 runtimes hex files
Implemented parsing of runtime metadata V14
Fixed tests
Fixed usages
Fixed some warnings in old files