Generate correct scipSymbol for namespace imports

[valerybugakov]

Without changes introduced in this PR local 0 SCIP symbol is generated for the ts import.

Test plan

See the updated test snapshot. Comment out the FileIndexer changes to reproduce the previous behavior.

[varungandhi-src]

See the updated test snapshot. Comment out the FileIndexer changes to reproduce the previous behavior.

One thing I like to sometimes do here is first commit the test (and run update-snapshots -- so that tests are still passing) and then commit the fix with the updated snapshot. The commits are squashed when merging anyways, but the PR becomes slightly nicer to read (this commit is the fix, and here is how the snapshot output changed because of it). The flip side is that is becomes a bit more finicky if you want to go back and edit the test later. I've sometimes done this for PRs in scip-ruby this way; it also makes it easier to go back on look at older PRs even if it was only self-reviewed. For example:

• https://github.com/sourcegraph/scip-ruby/pull/107/commits
• https://github.com/sourcegraph/scip-ruby/pull/83/commits

I haven't seen other people do this though, so I'm not going to ask that you do the same, but just mentioning it as one option. 😅

[valerybugakov]

@varungandhi-src, I like your approach! Here's the line with the incorrectly generated symbol. And here's the update that fixes it.

[olafurpg]

This looks great. Thank you much @valerybugakov!

[olafurpg]

Nice find 👍🏻

[olafurpg]

One thing I like to sometimes do here is first commit the test (and run update-snapshots so that tests are still passing) and then commit the fix with the updated snapshot.

@varungandhi-src I regularly do this myself. It's a very helpful technique to verify that your diff actually fixes the issue.