codeintel: add ignore-engines based on yarn version #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, auto-indexing would fail in projects using Yarn version greater than 1.x.x with the error
➤ YN0050: The --ignore-engines option is deprecated; engine checking isn't a core feature anymore
. Example in the sg/sg repo: https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/code-graph/indexes/TFNJRkluZGV4Ojk1Mjk=.As determining the Yarn version can only be done reliably by invoking yarn (Im miffed about this), we have to move the check from
typescript.lua
inference script to runtime instead.Related PR in sourcegraph/sourcegraph: https://github.com/sourcegraph/sourcegraph/pull/43592
Test plan
Before, based on
typescript.lua
:After, based on new
typescript.lua
: