Infer symbol relationship for object literals property in return statement #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tement
Previously, scip-typescript didn't infer correct relationships between
the object literel property and interface property in return statements
like below:
```ts
interface Configuration {
property: number
}
export function returnStatement(): Configuration {
return {
property: 42,
}
}
```
This commit fixes this specific issue. This commit also adds a test case
for a situation where scip-typescript doesn't infer the relationship
today but tsserver does. We should fix that in the future.
olafurpg
changed the title
keynmol
approved these changes
Apr 20, 2023
|
Realized the previous logic failed as soon as you didn't have a toplevel return statement. I have a half-baked idea how to clean up the logic so that we pass down the inferred type while traversing the AST avoiding the need to look up parents (which is typically a sign of a broken abstraction IME). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, scip-typescript didn't infer correct relationships between the object literel property and interface property in return statements like below:
This commit fixes this specific issue. This commit also adds a test case for a situation where scip-typescript doesn't infer the relationship today but tsserver does. We should fix that in the future.
Test plan
See updated snapshot tests.