insights: Add no-op migrator for insights oob migration (#39894)

Author: CristinaBirkel

enterprise/internal/insights/insights.go

@@ -74,17 +74,18 @@ func InitializeCodeInsightsDB(app string) (edb.InsightsDB, error) {
 }
 
 func RegisterMigrations(db database.DB, outOfBandMigrationRunner *oobmigration.Runner) error {
+	var insightsMigrator oobmigration.Migrator
 	if !IsEnabled() {
-		return nil
-	}
-
-	insightsDB, err := InitializeCodeInsightsDB("worker-oobmigrator")
-	if err != nil {
-		return err
+		// This allows this migration to be "complete" even when insights is not enabled.
+		insightsMigrator = migration.NewMigratorNoOp()
+	} else {
+		insightsDB, err := InitializeCodeInsightsDB("worker-oobmigrator")
+		if err != nil {
+			return err
+		}
+		insightsMigrator = migration.NewMigrator(insightsDB, db)
 	}
 
-	insightsMigrator := migration.NewMigrator(insightsDB, db)
-
 	// This id (14) was defined arbitrarily in this migration file: 1528395945_settings_migration_out_of_band.up.sql.
 	if err := outOfBandMigrationRunner.Register(14, insightsMigrator, oobmigration.MigratorOptions{Interval: 10 * time.Second}); err != nil {
 		return errors.Wrap(err, "failed to register settings migration job")

enterprise/internal/insights/migration/migration_no_op.go

@@ -0,0 +1,27 @@
+package migration
+
+import (
+	"context"
+
+	"github.com/sourcegraph/sourcegraph/internal/oobmigration"
+)
+
+type migratorNoOp struct {
+}
+
+func NewMigratorNoOp() oobmigration.Migrator {
+	return &migratorNoOp{}
+}
+
+func (m *migratorNoOp) Progress(ctx context.Context) (float64, error) {
+	return 1, nil
+}
+
+func (m *migratorNoOp) Up(ctx context.Context) (err error) {
+
+	return nil
+}
+
+func (m *migratorNoOp) Down(ctx context.Context) (err error) {
+	return nil
+}