This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: Add no-op migrator for insights oob migration #39894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristinaBirkel
changed the title
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4c2ae85...a239d61.
|
efritz
approved these changes
Aug 3, 2022
|
Also closes #38555. |
leonore
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/39106
Description
We weren't registering our oob migration if code insights was disabled. This registers a no-op migrator that will always return 100% complete. This allows customers (without code insights) to upgrade past the point of this migration's deprecation (which will be the next version) without needing manual intervention.
Test plan
I tested this on a single docker deployment and verified that the migration completed to 100%. You could also verify this locally by disabling code insights.