remove extension registry UI and related GraphQL API (#45891)

Removes the extension registry UI and the GraphQL API that is necessary for the registry extension UI.

Any extensions that already exist locally or remotely can still be used with the enableLegacyExtensions site config flag and by enabling the extensions in your user settings.

This change is an intermediate step toward removing the extension registry (except the endpoint that's needed to support pre-4.0 Sourcegraph instances).

I think this PR has a 99% chance of going into the 4.4 release (2023-01-20) and not needing to be reverted. Subsequent PRs that actually make it impossible to use local or custom legacy extensions are still pending customer communication and confirmation. I hope we can merge other future PRs there as well, but there is a greater chance we'd need to revert them before 4.4. By making this PR first, it means less of a revert and more progress regardless of what we learn from customers.

Author: sqs

CHANGELOG.md

@@ -35,7 +35,7 @@ All notable changes to Sourcegraph are documented in this file.
 
 ### Removed
 
--
+- The extension registry no longer supports browsing, creating, or updating legacy extensions. Existing extensions may still be enabled or disabled in user settings and may be listed via the API. (The extension API was deprecated in 2022-09 but is still available if the `enableLegacyExtensions` site config experimental features flag is enabled.)
 
 ## 4.3.0
 

client/client-api/src/contribution.ts

@@ -3,12 +3,6 @@ import { Primitive } from 'utility-types'
 import { KeyPath } from '@sourcegraph/shared/src/api/client/services/settings'
 import { Expression, TemplateExpression } from '@sourcegraph/template-parser'
 
-// NOTE: You must manually keep this file in sync with extension.schema.json#/properties/contributes (and possibly
-// extension_schema.go, if your changes are relevant to the subset of this schema used by our Go code).
-//
-// The available tools for automatically generating the JSON Schema from this file add more complexity than it's
-// worth.
-
 /**
  * The given contribution type as it's specified in a package.json (expressions as strings)
  */

client/extension-api-types/README.md

@@ -2,5 +2,3 @@
 
 Extensions should use the `sourcegraph` package, not this package. This package is only for client applications
 that embed Sourcegraph extensions and need to communicate with them.
-
-See [Sourcegraph extensions documentation](https://docs.sourcegraph.com/extensions) for more information.

client/extension-api/README.md

@@ -5,5 +5,3 @@
 [![sourcegraph: search](https://img.shields.io/badge/sourcegraph-search-brightgreen.svg)](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/tree/packages/extension-api)
 
 This package contains only the types for the [Sourcegraph extension API](https://unpkg.com/sourcegraph/dist/docs/index.html) ([`sourcegraph.d.ts`](https://github.com/sourcegraph/sourcegraph/blob/main/packages/extension-api/src/sourcegraph.d.ts)).
-
-See [Sourcegraph extensions documentation](https://docs.sourcegraph.com/extensions) for more information.

client/shared/src/codeintel/legacy-extensions/util/api.ts

@@ -6,7 +6,7 @@ import * as sourcegraph from '../api'
 import { cache } from '../util'
 
 import { graphqlIdToRepoId, queryGraphQL } from './graphql'
-import { isDefined, sortUnique } from './helpers'
+import { isDefined } from './helpers'
 import { parseGitURI } from './uri'
 
 /**
@@ -148,31 +148,6 @@ export class API {
         )
     }
 
-    /**
-     * Determines via introspection if the GraphQL API has implementations available
-     *
-     * TODO(tjdevries) - Remove this when we no longer need to support pre-3.XX releases (not yet released)
-     */
-    public async hasImplementationsField(): Promise<boolean> {
-        const introspectionQuery = gql`
-            query LegacyImplementationsIntrospectionQuery {
-                __type(name: "GitBlobLSIFData") {
-                    fields {
-                        name
-                    }
-                }
-            }
-        `
-
-        interface IntrospectionResponse {
-            __type: { fields: { name: string }[] }
-        }
-
-        return (await queryGraphQL<IntrospectionResponse>(introspectionQuery)).__type.fields.some(
-            field => field.name === 'implementations'
-        )
-    }
-
     /**
      * Determines via introspection if the GraphQL API has local code intelligence available
      *
@@ -318,183 +293,6 @@ export class API {
         return symbolInfoFlexibleToCanonical(symbolInfoFlexible)
     }
 
-    /**
-     * Retrieves the revhash of an input rev for a repository. Throws an error if the
-     * repository is not known to the Sourcegraph instance. Returns undefined if the
-     * input rev is not known to the Sourcegraph instance.
-     *
-     * @param repoName The repository's name.
-     * @param revision The revision.
-     */
-    public async resolveRev(repoName: string, revision: string): Promise<string | undefined> {
-        const query = gql`
-            query LegacyResolveRev($repoName: String!, $rev: String!) {
-                repository(name: $repoName) {
-                    commit(rev: $rev) {
-                        oid
-                    }
-                }
-            }
-        `
-
-        interface Response {
-            repository: {
-                commit?: {
-                    oid: string
-                }
-            }
-        }
-
-        const data = await queryGraphQL<Response>(query, { repoName, rev: revision })
-        return data.repository.commit?.oid
-    }
-
-    /**
-     * Retrieve a sorted and deduplicated list of repository names that contain the
-     * given search query.
-     *
-     * @param searchQuery The input to the search function.
-     */
-    public async findReposViaSearch(searchQuery: string): Promise<string[]> {
-        const query = gql`
-            query LegacyCodeIntelSearch($query: String!) {
-                search(query: $query) {
-                    results {
-                        results {
-                            ... on FileMatch {
-                                repository {
-                                    name
-                                }
-                            }
-                        }
-                    }
-                }
-            }
-        `
-
-        interface Response {
-            search: {
-                results: {
-                    results: {
-                        // empty if not a FileMatch
-                        repository?: { name: string }
-                    }[]
-                }
-            }
-        }
-
-        const data = await queryGraphQL<Response>(query, { query: searchQuery })
-        return sortUnique(data.search.results.results.map(result => result.repository?.name)).filter(isDefined)
-    }
-
-    /**
-     * Retrieve all raw manifests for every extension that exists in the Sourcegraph
-     * extension registry.
-     */
-    public async getExtensionManifests(): Promise<string[]> {
-        const query = gql`
-            query LegacyExtensionManifests {
-                extensionRegistry {
-                    extensions {
-                        nodes {
-                            extensionID
-                            manifest {
-                                raw
-                            }
-                        }
-                    }
-                }
-            }
-        `
-
-        interface Response {
-            extensionRegistry: {
-                extensions: {
-                    nodes: {
-                        manifest?: { raw: string }
-                    }[]
-                }
-            }
-        }
-
-        const data = await queryGraphQL<Response>(query)
-        return data.extensionRegistry.extensions.nodes.map(extension => extension.manifest?.raw).filter(isDefined)
-    }
-
-    /**
-     * Retrieve the version of the Sourcegraph instance.
-     */
-    public async productVersion(): Promise<string> {
-        const query = gql`
-            query LegacyProductVersion {
-                site {
-                    productVersion
-                }
-            }
-        `
-
-        interface Response {
-            site: {
-                productVersion: string
-            }
-        }
-
-        const data = await queryGraphQL<Response>(query)
-        return data.site.productVersion
-    }
-
-    /**
-     * Retrieve the identifier of the current user.
-     *
-     * Note: this method does not throw on an unauthenticated request.
-     */
-    public async getUser(): Promise<string | undefined> {
-        const query = gql`
-            query LegacyCurrentUser {
-                currentUser {
-                    id
-                }
-            }
-        `
-
-        interface Response {
-            currentUser?: { id: string }
-        }
-
-        const data = await queryGraphQL<Response>(query)
-        return data.currentUser?.id
-    }
-
-    /**
-     * Creates a `user:all` scoped access token. Returns the newly created token.
-     *
-     * @param user The identifier of the user for which to create an access token.
-     * @param note A note to attach to the access token.
-     */
-    public async createAccessToken(user: string, note: string): Promise<string> {
-        const query = gql`
-            mutation LegacyCreateAccessToken($user: ID!, $note: String!, $scopes: [String!]!) {
-                createAccessToken(user: $user, note: $note, scopes: $scopes) {
-                    token
-                }
-            }
-        `
-
-        interface Response {
-            createAccessToken: {
-                id: string
-                token: string
-            }
-        }
-
-        const data = await queryGraphQL<Response>(query, {
-            user,
-            note,
-            scopes: ['user:all'],
-        })
-        return data.createAccessToken.token
-    }
-
     /**
      * Get the content of a file. Throws an error if the repository is not known to
      * the Sourcegraph instance. Returns undefined if the input rev or the file is
@@ -673,11 +471,11 @@ export interface RepoCommitPath {
     path: string
 }
 
-export type LocalCodeIntelPayload = {
+type LocalCodeIntelPayload = {
     symbols: LocalSymbol[]
 } | null
 
-export interface LocalSymbol {
+interface LocalSymbol {
     hover?: string
     def: Range
     refs?: Range[]
@@ -703,7 +501,7 @@ const isInRange = (position: sourcegraph.Position, range: Range): boolean => {
 }
 
 /** The response envelope for all blob queries. */
-export interface GenericBlobResponse<R> {
+interface GenericBlobResponse<R> {
     repository: { commit: { blob: R | null } | null } | null
 }
 

client/shared/src/commandPalette/CommandList.tsx

@@ -261,10 +261,7 @@ export class CommandList extends React.PureComponent<CommandListProps, State> {
                         ) : query.length > 0 ? (
                             <li className={this.props.noResultsClassName}>No matching commands</li>
                         ) : (
-                            <EmptyCommandList
-                                settingsCascade={this.state.settingsCascade}
-                                sourcegraphURL={this.props.platformContext.sourcegraphURL}
-                            />
+                            <EmptyCommandList settingsCascade={this.state.settingsCascade} />
                         )}
                     </ul>
                 </div>

client/shared/src/commandPalette/EmptyCommandList.tsx

@@ -1,6 +1,6 @@
 import React from 'react'
 
-import { ButtonLink, Text } from '@sourcegraph/wildcard'
+import { Text } from '@sourcegraph/wildcard'
 
 import { onlyDefaultExtensionsAdded } from '../extensions/extensions'
 import { SettingsCascadeOrError } from '../settings/settings'
@@ -11,13 +11,9 @@ import styles from './EmptyCommandList.module.scss'
 
 interface Props {
     settingsCascade?: SettingsCascadeOrError
-    sourcegraphURL: string
 }
 
-export const EmptyCommandList: React.FunctionComponent<React.PropsWithChildren<Props>> = ({
-    settingsCascade,
-    sourcegraphURL,
-}) => {
+export const EmptyCommandList: React.FunctionComponent<React.PropsWithChildren<Props>> = ({ settingsCascade }) => {
     // if no settings cascade, default to 'no active extensions'
     const onlyDefault = settingsCascade ? onlyDefaultExtensionsAdded(settingsCascade) : false
 
@@ -32,10 +28,6 @@ export const EmptyCommandList: React.FunctionComponent<React.PropsWithChildren<P
                     : 'Commands from your installed extensions will be shown when you navigate to certain pages.'}
             </Text>
 
-            <ButtonLink to={sourcegraphURL + '/extensions'} variant="primary">
-                Explore extensions
-            </ButtonLink>
-
             <PuzzleIllustration className={styles.illustration} />
         </EmptyCommandListContainer>
     )

client/shared/src/extensions/extension.ts

@@ -1,9 +1,8 @@
 import { asError, ErrorLike, isErrorLike } from '@sourcegraph/common'
 
-import * as GQL from '../schema'
 import { Settings, SettingsCascadeOrError } from '../settings/settings'
 
-import { ExtensionManifest, parseExtensionManifestOrError } from './extensionManifest'
+import { ExtensionManifest } from './extensionManifest'
 
 /**
  * The default fields in the {@link ConfiguredExtension} manifest (i.e., the default value of the
@@ -30,45 +29,6 @@ export interface ConfiguredExtension<K extends keyof ExtensionManifest = Configu
     readonly manifest: Pick<ExtensionManifest, K> | null | ErrorLike
 }
 
-/**
- * Describes a configured extension with an optional associated registry extension. Prefer using
- * {@link ConfiguredExtension} when it is not necessary to access the registry extension's metadata.
- *
- * @template X the registry extension type
- */
-export interface ConfiguredRegistryExtension<
-    X extends Pick<GQL.IRegistryExtension, 'id' | 'url' | 'viewerCanAdminister'> = Pick<
-        GQL.IRegistryExtension,
-        'id' | 'url' | 'viewerCanAdminister'
-    >
-> extends ConfiguredExtension<keyof ExtensionManifest> {
-    /** The extension's metadata on the registry, if this is a registry extension. */
-    readonly registryExtension?: X
-
-    /** The raw extension manifest (JSON), or null if there is none. */
-    readonly rawManifest: string | null
-}
-
-type MinimalRegistryExtension = Pick<GQL.IRegistryExtension, 'extensionID' | 'id' | 'url' | 'viewerCanAdminister'> & {
-    manifest: { raw: string } | null
-}
-
-/**
- * Converts to a {@link ConfiguredRegistryExtension} value.
- *
- * @template X the extension type
- */
-export function toConfiguredRegistryExtension<X extends MinimalRegistryExtension>(
-    extension: X
-): ConfiguredRegistryExtension<X> {
-    return {
-        id: extension.extensionID,
-        manifest: extension.manifest ? parseExtensionManifestOrError(extension.manifest.raw) : null,
-        rawManifest: extension?.manifest?.raw || null,
-        registryExtension: extension,
-    }
-}
-
 /** Reports whether the given extension is enabled in the settings. */
 export function isExtensionEnabled(settings: Settings | ErrorLike | null, extensionID: string): boolean {
     return !!settings && !isErrorLike(settings) && !!settings.extensions && !!settings.extensions[extensionID]