Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Update to the latest src-cli release #36050

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

olafurpg
Copy link
Member

@olafurpg olafurpg requested a review from eseliger May 25, 2022 19:57
@cla-bot cla-bot bot added the cla-signed label May 25, 2022
@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff d161202...f145f8e.

Notify File(s)
@eseliger internal/src-cli/consts.go

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, is the debug command new? other than that lgtm

@olafurpg olafurpg enabled auto-merge (squash) May 25, 2022 20:03
@olafurpg
Copy link
Member Author

@eseliger I noticed that src debug was new as well, the original PR sourcegraph/src-cli#731

The 3.40.0 release included this command but it looks like somebody forgot to run go generate ./doc/cli/references to update the auto-generated --help pages in this repo.

@olafurpg olafurpg merged commit eea9e6a into main May 25, 2022
@olafurpg olafurpg deleted the olafurpg/minimum-constant branch May 25, 2022 20:06
@DaedalusG
Copy link
Contributor

@eseliger @olafurpg that was me, I knew there was some auto generation of docs here but though it was part of the release process 🙃

@olafurpg
Copy link
Member Author

@DaedalusG no worries! 😄 The debug command looks great. The steps to generate the docs is documented here https://github.com/sourcegraph/src-cli/blob/main/DEVELOPMENT.md#releasing

@eseliger
Copy link
Member

The someone who forgot it was me, not your fault @DaedalusG 😬

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants