This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[feat] Adding a few DB triggers to delete permissions when items are soft deleted #48189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These entities are referenced via foreign key in the
user_repo_permissions
table, and are soft deleted potentially:All of them would leave rows in the user_repo_permissions table, which is not desired. The
user_external_account
one was the most problematic from the point of view of behavior ofauthzQuery
.This change only affects the new unified permissions table, old behavior is not affected.
Test plan
Tested locally, directly in the database with the following scenarios:
repo_id
are deleteduser_id
anduser_external_account
are deleteduser_id
are deleted