Skip to content

style(clang-tidy): Clean include headers of src/core/json #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

bavulapati
Copy link
Contributor

Reported by clang-tidy check misc-include-cleaner
Refs: sourcemeta/blaze#429

Reported by clang-tidy check `misc-include-cleaner`
Refs: sourcemeta/blaze#429

Signed-off-by: Balakrishna Avulapati <[email protected]>
@jviotti
Copy link
Member

jviotti commented May 18, 2025

As with the other PRs, please follow the include styles, like the actual ordering, <...> style, comments on why the system includes were pulled in, etc. Overall try to copy the current style in all of the files!

Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
Copy link
Contributor Author

@jviotti addressed the review comments. PTAL

Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

@jviotti jviotti merged commit 863da9f into sourcemeta:main May 21, 2025
13 checks passed
@bavulapati bavulapati deleted the include-clean-src-core-json branch May 21, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants