Skip to content

FIX: using high resolution images on iOS as localSourceImage yields blurred outputs #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2024
Merged

FIX: using high resolution images on iOS as localSourceImage yields blurred outputs #73

merged 3 commits into from
Aug 12, 2024

Conversation

ian-wd
Copy link

@ian-wd ian-wd commented Aug 12, 2024 •
edited by iBotPeaches
Loading

Tested the suggested fix from THIS thread and it seems to work well on my testings

Updated example app to include several images for testing.

Before
image

After
image

Notes:

  • issues seems to only occur when very large images are being downscaled
  • unable to reproduce the issue on android
  • don't see a need to add a prop for this since it's an iOS only fix

Fixes:

@ian-wd ian-wd requested a review from iBotPeaches August 12, 2024 04:39
@ian-wd ian-wd marked this pull request as ready for review August 12, 2024 11:49
@iBotPeaches iBotPeaches merged commit 0345c8f into master Aug 12, 2024
1 check passed
@iBotPeaches iBotPeaches deleted the ios-blurry-image branch August 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBotPeaches iBotPeaches iBotPeaches approved these changes

Assignees

@iBotPeaches iBotPeaches

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images lose resolution when loading them in the canvas
2 participants
@ian-wd @iBotPeaches