Add example configuring alternate SPI ports. #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oclyke
suggested changes
Feb 6, 2020
|
|
||
| const char *msg = "Hello world!"; | ||
|
|
||
| //SPIClass SPI(); //This is default and automatically defined on RedBoard/ATP/Nano. Uses pads 5/6/7 (SCK/MISO/MOSI). |
There was a problem hiding this comment.
Just a nit: you are correctly using the pad vs pin notation but perhaps a user would not understand that pads 5/6/7 are actually (13, 12, 11) on the RedBoard (w/ Uno pin naming scheme).
Should there be a note explaining this in this example?
|
Oops accidentally chose 'request changes' when 'comment' would have been more appropriate. |
|
Agreed. I added a few comments. It's hard not to overwhelm the user with a breakdown of pads vs. pins which I don't think should be in the example. Let me know if you think it needs more. |
|
I think that does it nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy. Just another example to show how to configure additional ports.