add configurable EEPROM length #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the flashContent buffer is declared on the stack it may be dynamically sized. the user can take advantage of this to allow for any size EEPROM up to the allocated 1 page of flash. - added 'allowedSize' member to EEPROMClass - added setter for allowedSize 'setLength' - adjusted 'length' to return allowedSize - adjusted 'writeBlockToEEPROM' to use the allowedSize of the EEPROM structure when checking flash memory. - added example usage to Example2_AllFunctions
|
In response to #126 |
rustycoat
reviewed
Feb 16, 2020
rustycoat
reviewed
Feb 16, 2020
added 2 commits
February 17, 2020 09:57
taking suggestions from @rustycoat
|
@rustycoat thanks for the comments. I've updated the notes in the header file and implemented the ternary consition in
|
|
Thanks @oclyke. I'm a homesteader living off grid without much technology or time for things like contributing to open source, but I greatly value the open source way of doing things. 20 years ago I was a software developer, but back then it was CVS not git and, even so, I barely remember that process :). Thanks for the instructions, hopefully I'll have some time to do my part the next time I spot a potential bug. |
writing to 8176 and above seems likely to cause a crash with 32 and 64-bit wide data types. restricting the size of EEPROM a little bit seems to nearly eliminate these problems. while this is not a true solution or a good fix it is good enough for now
nseidle
approved these changes
Mar 18, 2020
|
Looks good and tests good. Thanks for expanding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the flashContent buffer is declared on the stack it may be dynamically sized the user can take advantage of this to allow for any size EEPROM up to the allocated 1 page of flash
added 'allowedSize' member to EEPROMClass
added setter for allowedSize 'setLength'
adjusted 'length' to return allowedSize
adjusted 'writeBlockToEEPROM' to use the allowedSize of the EEPROM structure when checking flash memory.
added example usage to Example2_AllFunctions