Skip to content

Low Power examples: added extra Serial prints just before the TX&RX pins are disabled #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Low Power examples: added extra Serial prints just before the TX&RX pins are disabled #156

wants to merge 1 commit into from

Conversation

PaulZC
Copy link
Contributor

@PaulZC PaulZC commented Apr 22, 2020

Hi Owen,
I've added extra Serial prints and delays to the LowPower and LowPower_WithWake examples.
(I've left the others well alone!)
All the best,
Paul

Copy link
Contributor

@oclyke oclyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the clarity that your statements have added to the examples.

This PR is still targeting the master branch. From what I see on the internet you should be able to change the base branch to release-candidate fairly easily.

Thanks again

@PaulZC
Copy link
Contributor Author

PaulZC commented Apr 22, 2020

Many thanks Owen. I really thought I had branched from the release-candidate branch (and thought the PR would go back onto that branch automatically). Thanks for the tip though - that's really worth knowing. Apologies in advance if I muck it up again next time...!
All the best.

@oclyke
Copy link
Contributor

oclyke commented Apr 22, 2020

No worries - I am new to this as well. (First time we are actually using this procedure, woohoo!)

I still don't see the change. Maybe my use of the word 'base branch' was misleading - I don't think it matters what branch you fork off from - only which one you (the PR author) are asking to merge into. I can't seem to change this since you are the author, btw. But I think that you can change it just with a click or two at the top of this page.

Let me know how it goes.

@PaulZC
Copy link
Contributor Author

PaulZC commented Apr 22, 2020

Unfortunately I don't see the branch pull-down box, I only see a link to the master branch... :-(
image
I wonder if it is because the changes are approved?
Don't worry - I'll resubmit in the morning. (It's bedtime over here...)
All the best.

@PaulZC PaulZC closed this Apr 22, 2020
@PaulZC PaulZC deleted the PaulZC__LowPower_Example_Tweaks branch April 23, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants