-
Notifications
You must be signed in to change notification settings - Fork 39
Release #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #163
Conversation
Added extra Serial prints just before the TX&RX pins are disabled
This looks really good. I'm testing bits of it now. Are you intending to use 2017 compiler or 2018? I have to use 2018 to get any Arduino sketch to run properly. |
@nseidle intending to use 2018 - should already be in the master branch because I circumvented the process this morning |
I like the way the commit history looks here - mostly names of PRs that will be easy to translate into a changelog! In the future ideally it would be just PR merges in this branch |
I just did a ~200 hundred attach/detach interrupts and no crashes. Much improved! |
I'm not sure if there's a protocol, but given the the time since last core release and the number of changes (inc. the new Ambiq SDK), might I suggest it's time for core v1.1.0 instead of v1.0.31. This branch is working for me on my custom board (including the new interrupt fixes, which seem to have resolved issue #151 ), I've got it running a simulated logging campaign for 24hrs (and then some), and will report any issues. |
@stephenf7072 I am okay with that proposal. Our principal is to follow the Semantic Versioning guidelines. However our application of these is a little murky because we are not dictating the Arduino API. For example when we add a peripheral port - e.g. Serial - is that:
I suppose I was just being lazy by incrementing the patch number all the time. I also think that v1.1.0 is a good signpost marking the dawn of our new more standardized version management practices. Any thoughts from others? Any reason why I should not merge and create release 1.1.0? |
Thanks Owen, good to know. Ran all my logging/interrupts test code overnight and it's still going (where it would have crashed by now), happy days. |
Bring latest changes into master for release