Skip to content

Add flow control #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Add flow control #230

merged 2 commits into from
Jul 14, 2020

Conversation

nseidle
Copy link
Member

@nseidle nseidle commented Jul 10, 2020

This PR adds flow control support for all UARTs (0 and 1).

It was fairly straight forward. Below is the test sketch that shows CTS properly working. I haven't devised a succinct way to test RTS (output).

Uart SerialTest(1, 25, 12, 10, 17); //Instance, RX, TX, RTS, CTS

void setup()
{
SerialTest.begin(115200);
SerialTest.println("SerialTest online");
}

void loop()
{
SerialTest.println("Stop this text by pulling CTS(17) high");
}

@oclyke
Copy link
Contributor

oclyke commented Jul 10, 2020

Cool! My rough plan is to do a final release of v1.X.X before we release v2.0.0. I will include this in that (after reviewing it too).

All the open PRs are not in vain - at the very least they can help us implement the same features in mbed and v2.0.0

Copy link
Contributor

@oclyke oclyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I will merge. However please see my comment about changing the HAL. We can use our SDK mirror repo to better document and distribute fixes among our codebase. I have discussed this repo with Arpit and Ron at Ambiq and they are interested in using it to help discover / report bugs.

@oclyke oclyke merged commit 16894c2 into master Jul 14, 2020
@oclyke oclyke deleted the addFlowControl branch July 14, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants