Add support for differential ADC #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was easier to provide the constant pads for differential ADC than trying to modify ap3_set_pin_to_analog() to use a pad #.
|
Can we put a pin in this PR and plan to add this functionality in the v2.0.0 core? I ask because there are HUGE structural changes in 2.0.0. Things like pin2pad no longer exist, the special ADC pads no longer exist, etc... I think it would make more sense to make these things happen on the v2.0.0 side. Thoughts? btw release of v2.0.0 is coming up quite soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two ADC channels:
ADIFF0
ADIFF1
and allows user to read the analog value of the channel like this:
This allows the user to read differential sensors such as load cells and wheatstone bridges.
An example is included in the advanced directory. To support this, if user tries to read a diff pair, the two associated diff pins will be set to analog inputs and the ADC will be set to channel DIFF0 or DIFF1.
My only concern with this PR is that it's a bit inelegant. I had to add
pad2pin()function because it was easier than modifyingap3_set_pin_to_analog()and creating aap3_set_pad_to_analog().If needed, I can re-base this branch to the release candidate.