add upload maximums to boards #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #121 arduino requires each board to define its own maximum flash and data sizes this goes hand-in-hand with the upload.size.pattern and upload.size.regex(.data) fields in platform.txt both must be present to display sketch size information arduino should consider using inheritance in board definitions (see mbed targets.json) - it would save a lot of duplication
Wenn0101
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #121
arduino requires each board to define its own maximum flash and data sizes
this goes hand-in-hand with the upload.size.pattern and upload.size.regex(.data) fields in platform.txt
both must be present to display sketch size information
arduino should consider using inheritance in board definitions (see mbed targets.json) - it would save a lot of duplication