Skip to content

Added LoRa Thing Plus Variant #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Added LoRa Thing Plus Variant #305

merged 6 commits into from
Jan 26, 2021

Conversation

dandobs
Copy link
Contributor

@dandobs dandobs commented Dec 9, 2020

Added LoRa Thing Plus as a variant and added to list of boards.
Generated mbed resources for variant.
Will submit PR to mbed os ambiq-apollo3-arduino branch to include files for target added to mbed.

Daniel Dobre and others added 2 commits November 16, 2020 15:05
@oclyke
Copy link
Contributor

oclyke commented Dec 17, 2020

@danJTDC, I suspect that the .mbed files for this PR were generated manually. This works well for testing but, due to the nature of the overall CI system we have developed, makes it difficult to test and maintain.

Once we can merge PR #42 in the mbed repo then this PR can be updated to include the ExpLoRaBLE variant in the variant generation action

Doing so will allow this PR to focus only on some key files like boards.txt, variant.h/c, and config/pins.h/cpp

Pete Lewis added 4 commits January 26, 2021 09:30
This was necessary for the radioLib examples of peer-to-peer (transmit/receive) to work with the expLoRaBLE.

Library found here: https://github.com/jgromes/RadioLib

In addition to enabling SPI, it also needed D40 available to fix a DIO1pin/timeout/IRQ related issue.
@@ -0,0 +1 @@
-c -x assembler-with-cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files should be generated automatically now that i completed the explorable PR in mbed.
Please update the generate-variants file with the explorable, and I will approve this PR so that we can test it and ensure that it is working.

@Wenn0101 Wenn0101 merged commit e77aa3a into sparkfun:dev Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants