Skip to content

EEPROM rewrite #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2019
Merged

EEPROM rewrite #75

merged 9 commits into from
Oct 23, 2019

Conversation

nseidle
Copy link
Member

@nseidle nseidle commented Oct 16, 2019

Write speed decreased from 30ms to 19ms due to block writing instead of multi-byte writes. Works with arbitrary length variables such as char arrays.

nseidle and others added 9 commits October 13, 2019 21:27
This uses the more common EEPROM methods currently built into Arduino. The approach is a lot more complex but handles any size variable and struct more gracefully than previous approach.

I originally hit this problem when trying to record a struct. This new approach works flawlessly.

Tested against examples and various attempts to break it.
Write speed decreased from 30ms to 19ms due to block writing instead of multi-byte writes. Works with arbitrary length variables such as char arrays.
This helps verify the EEPROM lib is erasing flash.
…!). Update comments.

Now works up to 2096 bytes of flash based EEPROM.
@nseidle
Copy link
Member Author

nseidle commented Oct 21, 2019

Note: This new EEPROM branch supports 1024 and 2048 bytes of pseudo EEPROM. For reasons unknown it would crash if increased beyond 2048. I suspect it may be related to what Paul found about aligned access in issue 78: #78.

@oclyke oclyke merged commit 81ee950 into master Oct 23, 2019
@oclyke oclyke deleted the eepromRewrite branch October 23, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants