Tensorflow micro lite compatibility #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should be pretty uncontroversial - instead of always initializing the ADC it will only happen the first time analogRead gets called. This prevents surprises when runnin bare-HAL code
This is more controversial. We need to figure out how this plays with examples and such. The reason for removing these is that they seem to conflict with the STL library, and that is used in TFLM.
|
Here's a tidbit: http://www.suodenjoki.dk/us/archive/2010/min-max.htm |
After discussion with Kirk we agreed that ```that's just the way it is``` in Arduino. Solved the TFLM example support by simply placing this at the top of the example ``` c++ #ifdef min #undef min #endif #ifdef max #undef max #endif ```
|
I like the adc setup fix. I think the #ifdef undef fix is fine. If min/max functions are wrong because of our overwriting, the user has bigger problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nseidle these are some changes that I had to make when getting the TFLM code to run on Edge. My concern is about the 2nd commit. Maybe one solution would be to implement a template function that could be used wherever the original macro would have been used. That way the signatures can be different (conflict is with
minas used here):stl_algobase.h