Correct preprocessor directive syntax #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous incorrect syntax cause compilation of the library to fail:
SparkFun_CCS811_Arduino_Library\src\SparkFunCCS811.cpp:61:8: error: macro names must be identifiers
#ifdef (ARDUINO_ARCH_ESP32 ARDUINO_ARCH_ESP8266)
^
Note that compilation for ESP32 still fails with a different error:
SparkFun_CCS811_Arduino_Library\src\SparkFunCCS811.cpp:62:7: error: 'class TwoWire' has no member named 'setClockStretchLimit'
Wire.setClockStretchLimit(200000);// was defautl 230 uS, now 200ms
^
From espressif/arduino-esp32#81, it's not clear whether there are plans to ever add the setClockStretchLimit function for ESP32.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous incorrect syntax caused compilation of the library to fail:
SparkFun_CCS811_Arduino_Library\src\SparkFunCCS811.cpp:61:8: error: macro names must be identifiers
Note that, after this fix, compilation for ESP32 still fails with a different error:
From espressif/arduino-esp32#81, it's not clear whether there are plans to ever add the
setClockStretchLimitfunction for ESP32. Perhaps @LGKev would care to comment on whether there is a good reason to call this function when compiling for ESP32.Fixes #9
CC: @bfaliszek