Skip to content

Fix reset to use system definition of digital write #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix reset to use system definition of digital write #15

merged 1 commit into from
Apr 4, 2022

Conversation

ajowsey
Copy link

@ajowsey ajowsey commented Apr 4, 2022

Within init(), reset(1) is called if a hardware reset is provided:
}
if (hardware) {
// Check if bit 2 of REG_MISC is set
// if so nReset will not issue a POR, we'll need to clear that bit first
byte regMisc = readByte(REG_MISC);
if (regMisc & (1 << 2)) {
regMisc &= ~(1 << 2);
writeByte(REG_MISC, regMisc);
}
// Reset the SX1509, the pin is active low
pinMode(pinReset, OUTPUT); // set reset pin as output
digitalWrite(pinReset, LOW); // pull reset pin low
delay(1); // Wait for the pin to settle
digitalWrite(pinReset, HIGH); // pull reset pin back high
}

The bolded lines of code above assume your Arduino will reset the io expander using the gpio assigned to pinReset. Problem is that this library actually calls SX1509::digitalWrite() instead of the Arduino digitalWrite. So the hardware reset never occurs

@nseidle
Copy link
Member

nseidle commented Apr 4, 2022

Looks good! Thank you.

@nseidle nseidle merged commit 3a0bc16 into sparkfun:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants