This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Long UBX packet may be lost as checksum failed. #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Welcome to your first PR. I don't think the ubxFrameCounter has to do with the protocol version coming back corrupt. The getProtocolVersion() method is pretty fragile and if any comm goes wrong, the value gets corrupt. I'll accept this PR because I think the ubxFrameCounter should be uint16_t but I have more work to do on the getProtocolVersion problem. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's first time to pull request on github for me.
When I use NEO-M8N module, and run the example #7 "GetProtcolVersion",
the version is shown as "0.0" instead of "18.0".
After straggling debug, I found the ubxFrameCounter is overflowed and rolling checksums are not correct.
When MON-VER is sent, NEO-M8N returns 260bytes UBX frame : 8bytes header, 250 bytes payload (40bytes soft/hard version and 7 x 30bytes extensions), and 2bytes checksums.
The default ubxFrameCounter is defined as uint8_t, so it counts till 255 and rollovers to 0 and checksums are reset.
I modified type of ubxFrameCounter from uint8_t to uint16_t.
It works fine!