Skip to content

Height scrolling error #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
klivak opened this issue Mar 25, 2019 · 3 comments
Closed

Height scrolling error #1

klivak opened this issue Mar 25, 2019 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@klivak
Copy link

klivak commented Mar 25, 2019

Hi, I used it on my Laravel + Vue project.
Added it for global usage.
It's working, but only when I scroll for 30px maybe.
The height of the page is more than 100vh, but top line goes from 0 to 100% when I scroll for 20-30px.
http://prntscr.com/n2ogqp

Could you help me to understand what's wrong?

@spemer
Copy link
Owner

spemer commented Mar 26, 2019

Hi,

It seems like the total height of the website that you capture, is not that high.
The top line goes 100% when scrollbar reaches bottom of the page.
So when if your website's total height is (100vh + 30px) and you scroll for 30px,
the top line will go to 100%.

I hope this can help you!

@klivak
Copy link
Author

klivak commented Mar 26, 2019

Hi, thanx for reply.
The height of the page is more than 100vh + 30px.
http://prntscr.com/n2zree

Really can't figure out what's wrong. Will try some test today.

@klivak
Copy link
Author

klivak commented Mar 26, 2019

Oh, I figure out what's wrong.
You are getting the height of the page when the page is loaded.
But in my case, I am loading some data with ajax. And my page height has changed, but you plugin didn't get that's event.

I understand it when i set to body fixed height:
body { height: 3000px; }
and that's work.

I think this plugin need some updates with eventListener for resize.

P.S. Sorry for mistakes, hope you understand.

@spemer spemer added the good first issue Good for newcomers label Mar 26, 2019
@spemer spemer closed this as completed in e7c0feb Mar 26, 2019
spemer added a commit that referenced this issue Mar 26, 2019
@spemer spemer self-assigned this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants