Texts in the classic html theme should be hyphenated. #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably go to stable branch... |
|
It wont work without #2282 ... |
|
Is there a reason this cannot live in |
|
@lehmannro Because the basic theme does not enforce text alignment to be justified, so it's not necessary to do. But you may be right that it is better to hyphenate even if it's not justified. |
|
I can move this to the "basic" theme if you want to. |
|
I'll take a look later. MEMO: hyphens property definition in CSS3 |
xuhdev
force-pushed
the
classic-hyphens
branch
from
ed29ab4 to
f4e6e68
Compare
|
I've changed the styling to the basic theme---I now consider it generally better, even without justified text alignment. |
To avoid "river of white".
xuhdev
force-pushed
the
classic-hyphens
branch
from
f4e6e68 to
b55b690
Compare
|
Oh, sorry. I intended to comment. LGTM :-) It looks fine. +1 for merge! Before: After: |
|
Any plan to merge this :) |
tk0miya
added a commit
that referenced
this pull request
Mar 1, 2016
Texts in the classic html theme should be hyphenated.
tk0miya
added a commit
that referenced
this pull request
Mar 1, 2016
|
Thank you always! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid "river of white".
This currently works well in Firefox, but Chromium seems not supporting it well yet (but does not hurt anyway).