Add support for meta description #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
force-pushed
the
no-override-manual-meta-description
branch
from
ab44d47 to
5025905
Compare
|
Rebased to resolve conflicts, and renamed option to |
hugovk
force-pushed
the
no-override-manual-meta-description
branch
from
5025905 to
161f2b5
Compare
|
Updated for #65 (comment). Still TODO: add documentation. |
|
Docs added, ready for review! |
TheTripleV
requested changes
Oct 25, 2022
TheTripleV
approved these changes
Oct 26, 2022
TheTripleV
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65.
Re: #65 (comment).
When
ogp_enable_meta_description=True, only add a generated<meta name="description" content="...">tag if the page doesn't already have a manual one.For example, a manual override may have been added using this RST:
Also fix a bug where it was adding multiple meta descriptions for subpages.
TODO:
ogp_enable_meta_description