Add dockerfile for windows server container build

[rhockenbury]

Proposed changes

This PR introduces a Dockerfile for windows server containers to support hybrid clusters for splunk-connect for kubernetes - splunk/splunk-connect-for-kubernetes#163

I would need assistance with getting the .circleci config right to build the windows container.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING doc
• I have read the CLA
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in downstream modules

[chaitanyaphalak]

Thanks for making the changes generic, will test it and get back to you.

[rhockenbury]

FYI - Currently hitting some snags with the net-http-persistent dependency of this module - drbrain/net-http-persistent#90. Also, we're expermenting with using record_transformer as a replacement for jq plugin due to this issue - zliang-min/fluent-plugin-jq#1

[rhockenbury]

So we've moved to using net-http-persistent 2.9.4 since the PR to fix that drbrain/net-http-persistent#90 isn't going to be merged anytime soon. The changes from the jq plugin to the record_transformer plugin will be reflected when the PR is open with the configMap.

[rhockenbury]

@chaitanyaphalak
Would it be possible for the splunk folks to host a fork of this with the patch applied, and publish the gem? Alternatively, the use of net-http-persistent could be changed in this repo so that splunk-hec gem still works with older versions of net-http-persistent.

[chaitanyaphalak]

@rhockenbury we recently merged a PR with a refactor removing net http persistent. You might need to validate this again.

[rhockenbury]

Can you clarify? I see that library used here - https://github.com/splunk/fluent-plugin-splunk-hec/blob/develop/lib/fluent/plugin/out_splunk_hec.rb#L10

[chaitanyaphalak]

The library is still there.

[rhockenbury]

Good news. The patch for net-http-persistent was merged. Once they put a new release out, and the version is bumped in fluent-plugin-splunk-hec, it should work on windows.

[rhockenbury]

@chaitanyaphalak Would you be able to bump the version of net-http-persistent so that the min version pulled in is 3.1.0? 3.1.0 contains the fix for the windows bug - https://github.com/drbrain/net-http-persistent/releases

[rhockenbury]

Also, haven't worked with circleci before, but we'll need to update the config to build the windows image. I'm happy to take a stab at it, but might be quicker if someone with experience with the build pipeline for this project did it - https://circleci.com/docs/2.0/hello-world-windows/. @chaitanyaphalak Any thoughts on this?

[chaitanyaphalak]

@rhockenbury for the net-http-persistent plugin we can bump the version at release or with your PR. I am not sure when this PR will be merged as we currently don't have access to windows nodes. Similarly, I havent worked with windows images on circleCI, but looking at the link you shared it looks it's easy enough to get some builds working. Again, adding the images to the CI dosen't make sense until this PR is validated, so I would update the CI for building windows images as another PR after we merge this PR.

[rhockenbury]

Opened #104 for the dependency bump.

Has the situation changed at all with regards to the ability to run windows nodes? Both AKS and GKE have preview support for running windows nodes - do the test clusters happen to run on either of those two platforms?

[hvaghani221]

As of now, there is no plan to support windows nodes. Closing the PR