Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Cannot launch composed tasks #5072

Closed
aruiz14 opened this issue Aug 31, 2022 · 2 comments · Fixed by #5074
Closed

Cannot launch composed tasks #5072

aruiz14 opened this issue Aug 31, 2022 · 2 comments · Fixed by #5074
Assignees
Milestone

Comments

@aruiz14
Copy link

aruiz14 commented Aug 31, 2022

Description:

Trying to launch a very simple composed task definition results in the following error:

Failed to resolve MavenResource: org.springframework.cloud:spring-cloud-dataflow-composed-task-runner:jar:@dataflow.version@. Configured remote repository: : [springRepo]

Release versions:
I think that only the latest 2.9.5 version is affected, while 2.9.4 works well.

Steps to reproduce:

  1. Start from a fresh installation.
  2. Add applications
    2.1 "Stream application starters for RabbitMQ/Maven"
    2.2 "Task application starters for Maven"
  3. Create a dummy composed task, with definition: 1: timestamp && 2:timestamp
  4. Go to the new task and try to launch it

Screenshots:
Screenshot 2022-08-31 at 15 44 06

Additional context:
From what I could observe, I think it's a problem with a variable interpolation affecting the spring.cloud.dataflow.task.composedtaskrunner.uri property in the spring-cloud-dataflow-server-core module. Probably missing from this PR ( #5014 ). I downloaded and extracted the .jar file for this version and I could check how spring-cloud-dataflow-server-core/src/main/resources/META-INF/dataflow-server-defaults.yml still contained @dataflow.version@:

META-INF/dataflow-server-defaults.yml
110:          uri: "maven://org.springframework.cloud:spring-cloud-dataflow-composed-task-runner:@dataflow.version@"
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Aug 31, 2022
@onobc onobc self-assigned this Sep 1, 2022
@onobc
Copy link
Contributor

onobc commented Sep 1, 2022

@aruiz14 thank you for the report and digging into the cause. We will get this addresses ASAP. In the meantime...

Workaround

Specify the property manually such as:

spring.cloud.dataflow.task.composedtaskrunner.uri=maven://org.springframework.cloud:spring-cloud-dataflow-composed-task-runner:2.9.5

OR as env var:

SPRING_CLOUD_DATAFLOW_TASK_COMPOSEDTASKRUNNER_URI=maven://org.springframework.cloud:spring-cloud-dataflow-composed-task-runner:2.9.5

ℹ️ NOTE This property is required at SCDF server start time (app content refresh) and therefore must be specified when launching the server. Unfortunately setting it as an app or deployment property at task launch time will have no effect.

onobc pushed a commit that referenced this issue Sep 1, 2022
onobc pushed a commit that referenced this issue Sep 1, 2022
@markpollack markpollack removed the status/need-triage Team needs to triage and take a first look label Sep 8, 2022
@markpollack markpollack modified the milestones: 2.9.6, 2.10.0-M2 Sep 8, 2022
@markpollack
Copy link
Contributor

Will make a 2.9.6 release to address this.

@markpollack markpollack reopened this Sep 8, 2022
@onobc onobc modified the milestones: 2.10.0-M2, 2.9.6 Sep 12, 2022
@onobc onobc closed this as completed Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants