Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Consider removing H2 dependency #5087

Open
onobc opened this issue Sep 10, 2022 · 4 comments
Open

Consider removing H2 dependency #5087

onobc opened this issue Sep 10, 2022 · 4 comments

Comments

@onobc
Copy link
Contributor

onobc commented Sep 10, 2022

So....

The H2 config was split into its own config and made optional in #4802 as it was lighting up CVE scans.

We quickly realized the missing dep. broke running locally w/ java -jar as well as many examples that do the same in the docs. Because of this I made the dependency non-optional here.

As of now the dependency is still provided. We need to decide what we are going to do in this area (provide it or not).

Originally posted by @onobc in #5082 (comment)

@onobc onobc added the for/team-attention For team attention label Sep 10, 2022
@onobc onobc added this to the 2.10.0 milestone Sep 10, 2022
@onobc
Copy link
Contributor Author

onobc commented Sep 15, 2022

From @jvalkeal ...

Lets follow up to see what Boot is doing in the version where H2 still has the CVE. IOW - if Boot has decided to leave it in we can follow suit based on the same principles.

Also is the latest H2 lib w/o the CVE able to run in SCDF?

@github-actions github-actions bot added status/need-feedback Calling participant to provide feedback and removed for/team-attention For team attention labels Sep 15, 2022
@markpollack markpollack removed the status/need-feedback Calling participant to provide feedback label Sep 22, 2022
@markpollack markpollack modified the milestones: 2.10.0, 2.10.1 Oct 13, 2022
@michael-wirth
Copy link
Contributor

Hi @onobc

From a developer's point of view, it is bad to have unnecessary dependencies on the classpath, just because of a "local/developer" setup and examples. In a prod environment normally a persistent database is used. In some companies, an h2database dependency will always raise a red flag even without CVE reports.

@onobc
Copy link
Contributor Author

onobc commented Dec 5, 2022

Hi @michael-wirth,
I agree w/ you and I would like to remove the dependency as well.

It is not that we want to use H2 specifically, or that we want it on the classpath.
Rather, we want it to be easy to start a local env for quickstart, local dev, manual testing, etc..
As you pointed out, the latter can be solved multiple ways. We just did not get a chance to get back to this in 2.10.0. We will aim for 2.10.1.

Thanks for the feedback.

@onobc
Copy link
Contributor Author

onobc commented Dec 5, 2022

GOAL: It should be easy to start a local env for quickstart, local dev, manual testing, etc..

Once H2 is removed from the class path here are some possible options to realize the above goal.

Option 1: Provide a script that adds the H2 dep to the local server

Option 2: Provide a script to start MariaDB locally in docker (it should output the command to start SCDF using the newly started MariaDB server)

Option 3:. Provide an artifact(s) that include the H2 dep

I am sure there are other options, just getting these thoughts queued up for when we get back to this.

@markpollack markpollack modified the milestones: 2.10.1, Priority Backlog Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants