Update database section of ref guide #5082
Conversation
spring-cloud-dataflow-docs/src/main/asciidoc/configuration-database.adoc
Show resolved
Hide resolved
spring-cloud-dataflow-docs/src/main/asciidoc/configuration-database.adoc
Show resolved
Hide resolved
| |=== | ||
|
|
||
| ==== H2 | ||
| When no other database is configured and the *H2* driver has been added to the server classpath then |
There was a problem hiding this comment.
Noob question, Is there a case where we do not include the H2 driver? If they don't specify a datasource dataflow defaults to H2.
There was a problem hiding this comment.
So....
The H2 config was split into its own config and made optional in #4802 as it was lighting up CVE scans.
We quickly realized the missing dep. broke running locally w/ java -jar as well as many examples that do the same in the docs. Because of this I made the dependency non-optional here.
As of now the dependency is still provided. We need to decide what we are going to do in this area (provide it or not). This doc is written as if it will be removed. Lets leave it like that for now and we will re-address the docs when we make a decision on H2.
Sound good @cppwfs ?
There was a problem hiding this comment.
I'm going to merge this and we can follow on w/ whatever we need to.
This handles the Dataflow ref guide updates - Skipper to follow.
Point1
I have created a common database adoc and included in both places that were previously talking about the details of which database/driver is supported etc..
Point2
This will not be the final suggested mechanism for users to extend the classpath as @corneil has another way that is less intrusive and will be addressed by spring-cloud-dataflow#5083.
Point3
I have attached generated PDF for your viewing pleasure while reviewing in case you do not have the IDEA asciidoc plugin etc.. These will NOT be checked in.
See #5079